-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fly.io provider #1
Conversation
3447f16
to
4c27813
Compare
aaaa544
to
aa461f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great. Nice work! Just please address the 2 small comments I left.
I'll test this on my machine later today and let you know if I encounter any issues.
aa461f5
to
5d21cfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the provider and it works as expected. Nice work!
There are still a couple of things to iron out that I've commented below.
One more thing I noticed. From the live logs of the machine, it seems that the repo got cloned again after I stopped then started the workspace. Does this mean that the home folder of the user is not persisted? If so, we will need to make adjustments since it's very important that the git repo persists when a project is restarted. |
5d21cfd
to
feee0fa
Compare
Machine / path is mounted to the volume but for stopped fly machine when you start the |
But volumes should be persistent. Also, you can not mount a volume to a directory that already exists in the image, that's why this "fails". I suggest you mount the volume to I will discuss with the rest of the team how to address the issue where the rest of the machine is reset to the original state. We will have to make it clear in the README somewhere. |
feee0fa
to
84933a5
Compare
I have updated the mounted path to
|
bed180c
to
229305a
Compare
229305a
to
0803a75
Compare
@bcmmbaga the code looks great now but I'm encountering weird errors again. Try to create a couple of workspaces in a row. I got this error on the third one: Seems there's still some race conditions going on. |
I will attempt to reproduce this issue. In the meantime, could you check if an app with this name exists on the Fly dashboard and confirm its status? |
The app is always present but remains in Pending state. |
I can confirm it is not a race error, as the error indicates that the machine is included in response from Fly.io. This seems to be related to Fly.io's end, as I have seen similar issues reported by other users when deploying: https://community.fly.io/t/app-stuck-on-pending/9550/13, https://community.fly.io/t/app-stuck-in-pending-state/4680 |
Is it possible to add some sort of check if the app is ready? I can see you implemented |
WaitForApp covers this scenario because an app in a pending state won't be returned in the API response. |
I suggest that we check the app status again and wait for the appropriate state. If the state isn't reach in 2 minutes, we can notify the user that there was a problem with their app. |
0803a75
to
9f93a7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bcmmbaga everything seems to be working great now. Nice work!
Approving this and you can merge yourself once we get one more approval. Please just update the commit message to include the feat:
subject (feat: add fly.io provider (#1))
. We follow https://www.conventionalcommits.org/en/v1.0.0/ in our org so we want that to be in sync with the rest of our repos.
I'll be opening up an issue immediately that should also be resolved before we release.
Signed-off-by: bcmmbaga <[email protected]>
9f93a7b
to
f05f085
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Add Fly.io Provider
Description
This pull request adds the implementation of Fly.io as a Daytona container provider.